Re: [PATCH 2/2] DT: leds: Add led-sources property
From: Bryan Wu <hidden>
Date: 2015-01-29 22:14:54
Also in:
linux-leds
On Thu, Jan 29, 2015 at 1:03 PM, Rob Herring [off-list ref] wrote:
On Thu, Jan 29, 2015 at 8:55 AM, Jacek Anaszewski [off-list ref] wrote:quoted
Hi Rob, Have we achieved consensus concerning this patch? If so, can you give your ack?I think so. Acked-by: Rob Herring <robh@kernel.org>quoted
OK, I can merge this patch into my tree with you guys Ack. Jacek, does this patch depend on the first one which you are still discussing with Pavel? Can I merge this one firstly. -Bryan
quoted
On 01/27/2015 09:07 AM, Jacek Anaszewski wrote:quoted
Add a property for defining device outputs the LED represented by the DT child node is connected to. Signed-off-by: Jacek Anaszewski <redacted> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Cc: Bryan Wu <redacted> Cc: Richard Purdie <redacted> Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <redacted> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <redacted> Cc: Kumar Gala <redacted> Cc: devicetree@vger.kernel.org --- Documentation/devicetree/bindings/leds/common.txt | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/leds/common.txtb/Documentation/devicetree/bindings/leds/common.txt index a2c3f7a..34811c5 100644--- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt@@ -1,6 +1,19 @@ Common leds properties. +LED and flash LED devices provide the same basic functionality as current +regulators, but extended with LED and flash LED specific features like +blinking patterns, flash timeout, flash faults and external flash strobemode. + +Many LED devices expose more than one current output that can be connected +to one or more discrete LED component. Since the arrangement of connections +can influence the way of the LED device initialization, the LED components +have to be tightly coupled with the LED device binding. They are represented +by child nodes of the parent LED device binding. + Optional properties for child nodes: +- led-sources : List of device current outputs the LED is connected to. The + outputs are identified by the numbers that must be defined + in the LED device binding documentation. - label : The label for this LED. If omitted, the label is taken from the node name (excluding the unit address).@@ -33,7 +46,8 @@ system-status { camera-flash { label = "Flash"; + led-sources = <0>, <1>; max-microamp = <50000>; flash-max-microamp = <320000>; flash-timeout-us = <500000>; -} +};-- Best Regards, Jacek Anaszewski