Re: Aw: [PATCH v5 3/4] tpm/st33zp24/spi: Add st33zp24 spi phy

On Wed, Jan 28, 2015 at 08:13:33PM +0100, RICARD Christophe wrote:

Hi Peter,

A TPM command can be up to 2048 byte, A TPM response can be up to 1024 byte.
Between command and response, there are latency byte (up to 15
usually on st33zp24 2 are enough).

Overall when sending a command and expecting an answer we need in
worst case:
2048 (for the TPM command) + 1024 (for the TPM answer).  We need
some latency byte before the answer is available (max 15).
We have 2048 + 1024 + 15.

I will go for a define making the code more readable together with a
comment.

You can probably just make these static arrays inside your priv
structure and drop these independent allocations:

quoted

+ phy->spi_xfer.tx_buf = devm_kmalloc(&dev->dev, (TPM_BUFSIZE +
+ (TPM_BUFSIZE / 2) + MAX_SPI_LATENCY),
+ GFP_KERNEL);

Jason
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html