Re: [PATCH RFC 2/3] power: mxs_power: add driver for mxs power subsystem
From: Stefan Wahren <hidden>
Date: 2015-01-26 19:46:45
Also in:
linux-arm-kernel, linux-pm
Hi,
Sebastian Reichel [off-list ref] hat am 25. Januar 2015 um 16:04 geschrieben: Hi, [add maintainers from regulator framework] On Thu, Jan 22, 2015 at 09:08:04AM +0100, Stefan Wahren wrote:quoted
Am 22.01.2015 um 00:01 schrieb Sebastian Reichel:quoted
On Thu, Nov 20, 2014 at 08:14:36PM +0000, Stefan Wahren wrote:quoted
This patch adds a minimal driver for the Freescale i.MX23, i.MX28 power subsystem. It's required to trigger the probing of the underlying drivers like on-chip regulators. Additionally the drivers supports the configuration of the DC-DC clock frequency to avoid possible interferences.I would expect PLL to be board specific and part of DT. Why is it specified as parameter?I think the switching frequency of the DC-DC belongs to the configuration and don't describe how the hardware is connected. But i don't have a problem to change it into a DT property. Does a common property name exists for the switching frequency or would it be vendor specific?As far as I know most regulators have fixed switching frequencies, so there is no common property name so far. I added regulator framework people, since this property should be regulator specific. Apart from introducing a custom/common switching-frequency property the dts could also expose the PLL like this and use the common clock-frequency property: power: power@80044000 { compatible = "fsl,imx28-power"; #address-cells = <1>; #size-cells = <1>; reg = <0x80044000 0x2000>; interrupts = <6>; ranges; powerpll { compatible = "fsl,imx28-power-pll" #clock-cells = <0>; clock-frequency = <12345>; } }
okay i understand. But doesn't it need a extra driver to set the switching frequency because of the new compatible string? At this point i think about moving this feature into the bootloader. @Fabio, @Marek: What's your opinion about that?
-- Sebastian
Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html