Re: [PATCH 2/2] ARM: at91: sama5d4: dts: change the nand compatible string

Hi, Brain

On 1/21/2015 4:49 AM, Brian Norris wrote:

On Mon, Jan 19, 2015 at 04:33:07PM +0800, Josh Wu wrote:

quoted

As we introduce a new "atmel,sama5d4-nand" compatible string for sama5d4,
so we need to apply it for sama5d4 chip.

Signed-off-by: Josh Wu <redacted>
---

  arch/arm/boot/dts/sama5d4.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index 1b0f30c..02d67c2 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi

@@ -267,7 +267,7 @@
  		};
  
  		nand0: nand@80000000 {
-			compatible = "atmel,at91rm9200-nand";
+			compatible = "atmel,sama5d4-nand";

Wouldn't it make sense to include both compatible strings, so that old
kernels can still bind to it?

yes, that make sense. I'll add it.

The newer IP only adds a new ECC feature,
but the driver still can work fine without handling it, right?

so far it works fine without this new feature. But I am not 100% sure 
for this :-)

Best Regards,
Josh Wu

quoted

  			#address-cells = <1>;
  			#size-cells = <1>;
  			ranges;

Brian

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html