Thread (7 messages) 7 messages, 4 authors, 2015-02-05

Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings

From: Eduardo Valentin <edubezval@gmail.com>
Date: 2015-01-31 19:29:41
Also in: dri-devel, linux-i2c, linux-pci, linux-pm, linux-pwm, linux-tegra, lkml

Hey Paul!

On Fri, Jan 30, 2015 at 03:11:04PM -0700, Paul Walmsley wrote:
Align compatible strings for several IP blocks present on Tegra chips
with the latest doctrine from the DT maintainers:

http://marc.info/?l=devicetree&m=142255654213019&w=2

The primary objective here is to avoid checkpatch warnings, per:

http://marc.info/?l=linux-tegra&m=142201349727836&w=2

DT binding text files have been updated for the following IP blocks:

- PCIe
- SOR
- SoC timers
- AHB "gizmo"
- APB_MISC
- pinmux control
- UART
- PWM
- I2C
- SPI
- RTC
- PMC
- eFuse
- AHCI
- HDA
- XUSB_PADCTRL
- SDHCI
- SOC_THERM
- AHUB
- I2S
- EHCI
- USB PHY

N.B. The nvidia,tegra20-timer compatible string is removed from the
nvidia,tegra30-timer.txt documentation file because it's already
mentioned in the nvidia,tegra20-timer.txt documentation file.

This second version takes into account the following requests from
Rob Herring [off-list ref]:

- Per-IP block patches have been combined into a single patch

- Explicit documentation about which compatible strings are actually
  matched by the driver has been removed.  In its place is implicit
  documentation that loosely follows Rob's prescribed format:

  "Must contain '"nvidia,<chip>-pcie", "nvidia,tegra20-pcie"' where
   <chip> is tegra30, tegra132, ..." [...]  "You should attempt to
   document known values of <chip> if you use it"


Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Alexandre Courbot <redacted>
Cc: Dylan Reid <redacted>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans de Goede <redacted>
Cc: Ian Campbell <redacted>
Cc: Jingchang Lu <redacted>
Cc: John Crispin <redacted>
Cc: Kumar Gala <redacted>
Cc: Linus Walleij <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Murali Karicheri <redacted>
Cc: Paul Walmsley <redacted>
Cc: Pawel Moll <redacted>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Peter Hurley <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sean Paul <redacted>
Cc: Stephen Warren <redacted>
Cc: Takashi Iwai <redacted>
Cc: Tejun Heo <tj@kernel.org>
Cc: "Terje Bergström" <redacted>
Cc: Thierry Reding <redacted>
Cc: Tuomas Tynkkynen <redacted>
Cc: Wolfram Sang <redacted>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
---
 .../bindings/arm/tegra/nvidia,tegra20-ahb.txt      |    5 ++++-
 .../bindings/arm/tegra/nvidia,tegra20-pmc.txt      |    6 +++++-
 .../devicetree/bindings/ata/tegra-sata.txt         |    4 +++-
 .../bindings/fuse/nvidia,tegra20-fuse.txt          |   10 +++++-----
 .../bindings/gpu/nvidia,tegra20-host1x.txt         |    8 ++++++--
 .../devicetree/bindings/i2c/nvidia,tegra20-i2c.txt |   10 +++++-----
 .../bindings/misc/nvidia,tegra20-apbmisc.txt       |    9 ++++-----
 .../bindings/mmc/nvidia,tegra20-sdhci.txt          |    6 +++++-
 .../bindings/pci/nvidia,tegra20-pcie.txt           |    8 ++++----
 .../bindings/pinctrl/nvidia,tegra124-pinmux.txt    |    3 ++-
 .../pinctrl/nvidia,tegra124-xusb-padctl.txt        |    4 +++-
 .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt |    7 ++++---
 .../devicetree/bindings/rtc/nvidia,tegra20-rtc.txt |    4 +++-
 .../devicetree/bindings/serial/of-serial.txt       |    5 ++++-
 .../bindings/sound/nvidia,tegra30-ahub.txt         |    5 ++++-
 .../bindings/sound/nvidia,tegra30-hda.txt          |    4 +++-
 .../bindings/sound/nvidia,tegra30-i2s.txt          |    5 ++++-
 .../bindings/spi/nvidia,tegra114-spi.txt           |    4 +++-
 .../devicetree/bindings/thermal/tegra-soctherm.txt |    4 +++-
<cut>
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
index ecf3ed76cd46..6b68cd150405 100644
--- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
+++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
@@ -7,7 +7,9 @@ notifications. It is also used to manage emergency shutdown in an
 overheating situation.
 
 Required properties :
-- compatible : "nvidia,tegra124-soctherm".
+- compatible : For Tegra124, must contain "nvidia,tegra124-soctherm".
+  For Tegra132, must contain "nvidia,tegra132-soctherm".
+  For Tegra210, must contain "nvidia,tegra210-soctherm".
 - reg : Should contain 1 entry:
   - SOCTHERM register set
 - interrupts : Defines the interrupt used by SOCTHERM
Considering that this is going into a single patch, you may add my

Acked-by: Eduardo Valentin <edubezval@gmail.com>

for what concerns the thermal bindings.

Cheers,

Eduardo Valentin

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help