Thread (11 messages) 11 messages, 3 authors, 2015-02-03

Re: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

From: Stephen Boyd <hidden>
Date: 2015-01-30 21:37:54
Also in: linux-arm-kernel, linux-arm-msm, lkml

On 01/30/15 08:32, Kumar Gala wrote:
On Jan 30, 2015, at 12:25 AM, Andy Gross [off-list ref] wrote:
quoted
Required properties if child node exists:
- #address-cells: Must be 1
- #size-cells: Must be 1
- ranges: Must be present

+Note: Each GSBI should have an alias correctly numbered in "aliases" node.
+
Properties for children:

A GSBI controller node can contain 0 or more child nodes representing serial
@@ -37,6 +41,10 @@ Example for APQ8064:
#include <dt-bindings/soc/qcom,gsbi.h>

+	aliases {
+		gsbi4 = <&gsbi4>;
+	};
You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi’s for this purpose.
I thought cell-index was "deprecated" and referred more to things like
enumerating all the devices on a bus by assigning them a unique ID.
Aliases, on the other hand, allow us to enumerate a subset of devices
that share the same bus with other devices of different types. For
example, how would I know that a device is gsbi1 vs serial1 if they both
used cell-index and they both had the same parent node?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help