Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors

Joonyoung Shim [off-list ref] writes:

Hi Kevin,

On 01/15/2015 10:08 AM, Kevin Hilman wrote:

quoted

From: Kevin Hilman <redacted>

The odroid-xu3 has 4 INA231 current sensors on board which can be
accessed from the Linux via the hwmon interface.

There is one sensor for each of these power rails:

- A15 cluster: VDD_ARM
- A7 cluster: VDD_KFC
- GPU: VDD_G3D
- memory: VDD_MEM

In addition to adding the sensors, LDO26 from the PMIC needs to be
enabled because it's powering these sensor.

Cc: Javier Martinez Canillas <redacted>
Cc: Sjoerd Simons <redacted>
Signed-off-by: Kevin Hilman <redacted>
---
v2: use "ti,ina231" as compatible string.

Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.

 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index c29123c0734d..50353d023225 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts

@@ -174,6 +174,13 @@
 					regulator-always-on;
 				};
 
+				ldo26_reg: LDO26 {
+					regulator-name = "vdd_ldo26";
+					regulator-min-microvolt = <3000000>;
+					regulator-max-microvolt = <3000000>;
+					regulator-always-on;
+				};
+
 				buck1_reg: BUCK1 {
 					regulator-name = "vdd_mif";
 					regulator-min-microvolt = <800000>;

@@ -257,6 +264,38 @@
 		};
 	};
 
+	i2c_0: i2c@12C60000 {

It's ok but IMHO it can split using label reference, e.g. 

&i2c_0 {
	...
};

Yes, you're right.  I'll spin a v3.

Kevin