Thread (17 messages) 17 messages, 3 authors, 2015-01-23

Re: [PATCH v2 4/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

From: Sneeker Yeh <hidden>
Date: 2015-01-21 08:55:57
Also in: linux-omap, lkml

hi,

2015-01-19 22:51 GMT+08:00 Felipe Balbi [off-list ref]:
On Mon, Jan 19, 2015 at 03:56:48PM +0800, Sneeker Yeh wrote:
quoted
If an xhci platform has Synopsis device disconnection errata then enable
XHCI_DISCONNECT_QUIRK quirk flag.

Signed-off-by: Sneeker Yeh <redacted>
---
 drivers/usb/host/xhci-plat.c     |    3 +++
 include/linux/usb/xhci_pdriver.h |    4 ++++
 2 files changed, 7 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 08d402b..40beb95 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -147,6 +147,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
      if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
                      (pdata && pdata->usb3_lpm_capable))
              xhci->quirks |= XHCI_LPM_SUPPORT;
+
+     if (pdata && pdata->delay_portcsc_clear)
+             xhci->quirks |= XHCI_DISCONNECT_QUIRK;
      /*
       * Set the xHCI pointer before xhci_plat_setup() (aka hcd_driver.reset)
       * is called by usb_add_hcd().
diff --git a/include/linux/usb/xhci_pdriver.h b/include/linux/usb/xhci_pdriver.h
index 376654b..a37a3a5 100644
--- a/include/linux/usb/xhci_pdriver.h
+++ b/include/linux/usb/xhci_pdriver.h
@@ -18,10 +18,14 @@
  *
  * @usb3_lpm_capable:        determines if this xhci platform supports USB3
  *                   LPM capability
+ * @delay_portcsc_clear:     determines if Synopsis USB3 core has errata in
+ *                           "DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1" hardware
+ *                           configuration.
  *
  */
 struct usb_xhci_pdata {
      unsigned        usb3_lpm_capable:1;
+     unsigned        delay_portcsc_clear:1;
previous patch won't build before this is applied. That's a problem.
Please shuffle things around so that each and every patch builds and
works on its own.

We cannot break bisectability ;-)
Ah...sorry I seem to make a mess here,
i'll re-arrange all patches next round.

Much appreciate,
Sneeker
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help