Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

On 1/15/2015 4:07 AM, Wolfram Sang wrote:

quoted

quoted

+static int bcm_iproc_i2c_remove(struct platform_device *pdev)
+{
+	struct bcm_iproc_i2c_dev *iproc_i2c = platform_get_drvdata(pdev);
+
+	i2c_del_adapter(&iproc_i2c->adapter);

You need to free the irq before i2c_del_adapter.

One could also keep using devm_request_irq and disable all interrupts
sources here?

Okay this makes sense. Will use devm_request_irq and disable interrupt
in the remove function. Thanks.

Thanks for the reviews, Uwe!

   Wolfram