Thread (10 messages) 10 messages, 4 authors, 2015-01-16

Re: [Patch v5 2/2] gpio: Document GPIO hogging mechanism

From: Linus Walleij <hidden>
Date: 2015-01-12 10:20:18
Also in: linux-gpio, lkml

On Fri, Dec 19, 2014 at 9:07 PM, Benoit Parrot [off-list ref] wrote:
Add GPIO hogging documentation to gpio.txt

Signed-off-by: Benoit Parrot <redacted>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
This is starting to look good ...
+               line_b {
+                       gpio-hog;
+                       gpios = <6 0>;
+                       state = "output-low";
I don't like the state string.

Instead have boolean properties for all states.

line_b {
    gpio-hog;
    gpios = <6 0>;
    output-low;
    line-name = "foo-bar-gpio";
}

Then use of_property_read_bool() in the code to check which
state is to be selected intially. You can check that no mutually
exclusive state are selected, I don't like that an arbitrary string
select the state like that, if we do it that way an enumerator would
be better, I prefer bools.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help