Re: [PATCH 2/2] iio: mxs-lradc: check ranges of ts properties

On 26/12/14 20:50, Stefan Wahren wrote:

Hi Jonathan,

quoted

Jonathan Cameron [off-list ref] hat am 26. Dezember 2014 um 10:23
geschrieben:

[...]

quoted

- lradc->over_sample_delay = 2;
- ret = of_property_read_u32(lradc_node, "fsl,ave-delay", &adapt);
- if (ret == 0)
+ if (of_property_read_u32(lradc_node, "fsl,ave-delay", &adapt)) {
+ lradc->over_sample_delay = 2;
+ } else {
+ if (adapt < 2 || adapt > LRADC_DELAY_DELAY_MASK+1) {

please run checkpatch.pl over these. Should be spaces around the +

i'm afraid my checkpatch.pl doesn't find this issue. I'll fix it in the next
version.

So it doesn't!  Sorry about the false comment.

Hmm. I wonder why...