Re: [PATCH v4 5/5] media: ov2640: dt: add the device tree binding document
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date: 2014-12-18 12:13:23
Also in:
linux-arm-kernel, linux-media
Hi Josh, On 18/12/14 03:27, Josh Wu wrote:
Add the document for ov2640 dt. Cc: devicetree@vger.kernel.org Signed-off-by: Josh Wu <redacted>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> It seems "ovti" is not in the list of vendor prefixes. You may want to send a patch adding it to Documentation/devicetree/bindings/ vendor-prefixes.txt. Just few minor comments below..
quoted hunk ↗ jump to hunk
.../devicetree/bindings/media/i2c/ov2640.txt | 46 ++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2640.txtdiff --git a/Documentation/devicetree/bindings/media/i2c/ov2640.txt b/Documentation/devicetree/bindings/media/i2c/ov2640.txt new file mode 100644 index 0000000..de11ebb --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov2640.txt@@ -0,0 +1,46 @@ +* Omnivision ov2640 CMOS sensor
s/ov2640/OV2640 ?
+ +The Omnivision OV2640 sensor support multiple resolutions output, such as +CIF, SVGA, UXGA. It also can support YUV422/420, RGB565/555 or raw RGB +output format. + +Required Properties: +- compatible: Must be "ovti,ov2640"
I believe it is preferred to put it as "Should contain", rather than "Must be".
+- clocks: reference to the xvclk input clock. +- clock-names: Must be "xvclk".
-- Regards, Sylwester