Re: [PATCH v6 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

From
Doug Anderson <dianders@chromium.org>
Date
2014-12-11 18:41:42
Also in
linux-arm-kernel, lkml
Reply to
Kishon Vijay Abraham I, 2014-12-11
Kishon,

On Thu, Dec 11, 2014 at 2:27 AM, Kishon Vijay Abraham I [off-list ref] wrote:
I didn't mean that. You can get rid of this entire xlate stuff if you use
something like below

phy@xxx {
        compatible = "";
        phy1:usb_phy {
        }
        phy2:usb_phy {
        };
};


usb@xx {
        compatible = "";
        phys = <&phy1>; //doesn't need xlate
        /* this needs xlate
           phys = <&phy 1>;
        */
        phy-names = "phy";
};
Is the syntax you proposed really better?  Are you saying that you
advocate never using "#phy-cells" other than 0 for new bindings?  Is
that your own personal preference, or is there a discussion somewhere
where everyone agreed on this?

My vote is that since "phy-cells" exists and is part of the generic
phy bindings that it's meant to be used whenever you have a single PHY
driver that controls multiple PHYs.


-Doug
Thread (16 messages) 16 messages, 3 authors, last reply 2014-12-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help