Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding

On 12/9/2014 5:27 PM, Varka Bhadram wrote:

Hi,

On Wednesday 10 December 2014 06:24 AM, Ray Jui wrote:

quoted

Document the I2C device tree binding for Broadcom iProc family of
SoCs

Signed-off-by: Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Reviewed-by: Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---
  .../devicetree/bindings/i2c/brcm,iproc-i2c.txt     |   37
++++++++++++++++++++
  1 file changed, 37 insertions(+)
  create mode 100644
Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt

diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt

b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
new file mode 100644
index 0000000..81f982c

--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt

@@ -0,0 +1,37 @@
+Broadcom iProc I2C controller
+
+Required properties:
+
+- compatible:
+    Must be "brcm,iproc-i2c"
+
+- reg:
+    Define the base and range of the I/O address space that contain

the iProc
+    I2C controller registers
+
+- interrupts:
+    Should contain the I2C interrupt
+
+- clock-frequency:
+    This is the I2C bus clock. Need to be either 100000 or 400000
+
+- #address-cells:
+    Always 1 (for I2C addresses)
+
+- #size-cells:
+    Always 0
+

All the properties defined with two lines of statements.

Why cant they be with single line statement, like:

compatible:    Must be "brcm,iproc-i2c"
reg:        Define the base and range of the I/O address space that
         contain the iProc I2C controller registers

....

I thought making them two lines are more readable (and obviously that's very subjective, :)). But more importantly, it matches the format of other Broadcom iProc/Cygnus devicetree binding documents that are currently in progress of upstreaming.