Thread (9 messages) 9 messages, 2 authors, 2014-12-09

Re: [PATCH v3 3/3] ARM: tegra: Add Tegra124 ACTMON support

From: Alexandre Courbot <hidden>
Date: 2014-12-09 05:34:03
Also in: linux-arm-kernel, linux-pm, linux-tegra, lkml

On Fri, Dec 5, 2014 at 1:14 AM, Tomeu Vizoso [off-list ref] wrote:
Add device node for the ACTMON block to the Tegra124 device tree.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>

---

v3:     * Address misc. style issues found by Thierry and Alexander
        * Added helpers for register i/o
        * Further documented the structs
        * Enable the ACTMON after the IRQ handler has been installed
        * Disable the ACTMON before removing the IRQ handler
        * Add governor in a subsys initcall

v2:     * Add operating-points property
---
 arch/arm/boot/dts/tegra124.dtsi        |  23 +
 drivers/devfreq/Kconfig                |   7 +-
 drivers/devfreq/Makefile               |   2 +-
 drivers/devfreq/tegra-actmon-devfreq.c | 777 +++++++++++++++++++++++++++++++++
 drivers/devfreq/tegra-devfreq.c        | 718 ------------------------------
In patch 2/3 you create tegra-devfreq.c, to apparently move it to
tegra-actmon-devfreq.c and (seemingly) add somemore lines to it. This
makes things difficult to review, and I am almost sure this is a
naming mistake - could you fix this and resend?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help