Re: [PATCH 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen

Hi Geert,

On 11/13/2014 09:16 AM, Geert Uytterhoeven wrote:

On Thu, Nov 13, 2014 at 9:15 AM, Geert Uytterhoeven
[off-list ref] wrote:

quoted

On Wed, Nov 12, 2014 at 11:08 PM, Hans de Goede [off-list ref] wrote:

quoted

--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c

quoted

@@ -385,7 +386,37 @@ static struct platform_driver simplefb_driver = {
        .probe = simplefb_probe,
        .remove = simplefb_remove,
 };
-module_platform_driver(simplefb_driver);
+
+static int __init simplefb_init(void)
+{
+       int i, ret;

unsigned int i;

Although you're right that it will never become negative, making this
unsigned really gains us nothing, and it is normal C programming
practice to use signed ints to loop over arrays even if the array
index never becomes negative. So I see no reason to change this.

Regards,

Hans