Thread (48 messages) 48 messages, 14 authors, 2014-12-03

Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile

From: Mark Brown <broonie@kernel.org>
Date: 2014-11-28 14:52:17
Also in: linux-api, linux-arm-kernel, linux-serial, lkml

On Fri, Nov 28, 2014 at 02:44:12PM +0000, Will Deacon wrote:
On Fri, Nov 28, 2014 at 02:35:32PM +0000, Mark Rutland wrote:
quoted
Probably too rude, given it doesn't WARN() the user.
We override broken hardware ID registers all the time in device-tree without
dumping stack. Why is this any different?
I do tend to agree that a WARN() is excessive but given the amount of
pushback on using this property on ARMv8 systems saying something would
be nice, though...
quoted
We should be extremely loud if we see the clock-frequency property on an
arm64 system. Whether or not we should ignore the property is another
matter.
I don't really see the point in ignoring it. We will see broken hardware
[1] and this is just preventing ourselves from working around it. I'd much
rather have arch-timers with a "clock-frequence" property than have some
other timer instead because the kernel driver is being stubborn.
...it is likely that even if there is a warning we'll end up in this
situation.  If the kernel doesn't complain at all it seems totally
reasonable for people to use the feature, but just refusing to allow it
to be used at all doesn't seem like it's actually helping things.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help