Re: [PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

So we stick to using just the new string, right? Any more changes to this
patch ?

On Tue, Oct 7, 2014 at 6:05 PM, Mark Rutland [off-list ref] wrote:

On Tue, Oct 07, 2014 at 01:31:23PM +0100, Arnd Bergmann wrote:

quoted

On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:

quoted

On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:

quoted

On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:

quoted

                /* ALS and Proximity sensor */
                isl29028@44 {
-                       compatible = "isil,isl29028";
+                       compatible = "isl,isl29028";
                        reg = <0x44>;
                        interrupt-parent = <&gpio>;
                        interrupts = <TEGRA_GPIO(L, 0)

IRQ_TYPE_LEVEL_HIGH>;

quoted

quoted

quoted

quoted

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this

would

quoted

quoted

quoted

need to be

      compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they
do, but I don't think it should be necessary. Old DTBs should

definitely

quoted

quoted

work with a new kernel, though.

Personally I'd rather see one string (preferably the canonical one, but
the deprecated one is ok) than two strings when those strings are for
the exact same device.

Ok, fair enough. I think we should have the new name in dts files
normally then, in order to avoid spreading the mistake further when
someone copies it.

Sounds good to me.

Mark.

-- 

Regards
Darshana Padmadas <http://darshanapadmadas.wordpress.com>
ज्ञानं परमं ध्येयम्