On 10/09, Stephen Boyd wrote:

On 10/09, Lina Iyer wrote:

quoted

On Wed, Oct 08 2014 at 19:17 -0600, Stephen Boyd wrote:

quoted

quoted

+static int __init qcom_pm_device_init(void)
+{
+	platform_device_register(&qcom_cpuidle_device);
+

This is wrong. We're going to register a platform device whenever
this file is included in a kernel. This is then going to try and
probe the qcom_cpuidle device which is going to fail and print an
error message if we're not running on a qcom device.

Why would this file be compiled on a non-qcom target? The file has a
dependency on ARCH_QCOM (as it should be) and would not be compiled on a
non-qcom target.

We will compile this file on non-qcom devices in a multi-platform
kernel build. Actually that looks like it would be a problem
because cpuidle_register() will blow away any other registered
driver on non-qcom devices.

Oh right, this won't happen because we won't have the idle states
in the CPU node. We'll just get the annoying error message
instead.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project