Thread (104 messages) 104 messages, 14 authors, 2015-01-15

Re: [PATCH 05/13] misc: at25: Make use of device property API

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2014-10-07 09:32:12
Also in: linux-acpi, lkml

On Tue, Oct 07, 2014 at 11:10:23AM +0200, Geert Uytterhoeven wrote:
On Tue, Oct 7, 2014 at 2:14 AM, Rafael J. Wysocki [off-list ref] wrote:
quoted
@@ -301,35 +301,33 @@ static ssize_t at25_mem_write(struct memory_accessor *mem, const char *buf,

 /*-------------------------------------------------------------------------*/

-static int at25_np_to_chip(struct device *dev,
-                          struct device_node *np,
-                          struct spi_eeprom *chip)
+static int at25_fw_to_chip(struct device *dev, struct spi_eeprom *chip)
 {
        u32 val;

        memset(chip, 0, sizeof(*chip));
-       strncpy(chip->name, np->name, sizeof(chip->name));
+       strncpy(chip->name, "at25", sizeof(chip->name));
So this changes chip->name from "eeprom" (or whatever name the DTS
writer used; "eeprom" is the ePAPR-compliant name) to "at25"?
Yes.

Is there something depending on that name?
Note:The example in Documentation/devicetree/bindings/misc/at25.txt
uses "at25", not "eeprom".
Which is the same we use here.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help