Re: [PATCH 1/4] dt-bindings: Add a clocks property to the simple-framebuffer binding

Hi,

On 09/28/2014 08:37 PM, Mike Turquette wrote:

On Sun, Sep 28, 2014 at 5:43 AM, Hans de Goede [off-list ref] wrote:

quoted

A simple-framebuffer node represents a framebuffer setup by the firmware /
bootloader. Such a framebuffer may have a number of clocks in use, add a
property to communicate this to the OS.

Signed-off-by: Hans de Goede <redacted>

Acked-by: Mike Turquette <redacted>
or
Reviewed-by: Mike Turquette <redacted>

I don't know what is the right thing with these binding definitions...

Also I have one suggestion below:

quoted

---
 Documentation/devicetree/bindings/video/simple-framebuffer.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt
index 70c26f3..e75478e 100644
--- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt
+++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt

@@ -14,6 +14,9 @@ Required properties:
   - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b).
   - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r).

+Optional properties:
+- clocks : List of clocks used by the framebuffer
+
 Example:

        framebuffer {

It might be nice to add the clocks property to the example. Something like:

clocks = <&osc 1>, <&ref 0>;

Given the optional nature of the clocks, I've deliberately left them out,
but if people want to I can do a v2 with a clocks property added to the example.

Regards,

Hans