Re: [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip
From: Hauke Mehrtens <hidden>
Date: 2014-09-27 08:33:37
Also in:
linux-arm-kernel, linux-wireless
Possibly related (same subject, not in this thread)
- 2014-09-27 · Re: [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip · Hauke Mehrtens <hidden>
- 2014-09-27 · Re: [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip · Rafał Miłecki <hidden>
- 2014-09-27 · Re: [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip · Rafał Miłecki <hidden>
- 2014-09-26 · Re: [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip · Arnd Bergmann <hidden>
- 2014-09-26 · [PATCH] bcma: use device from DT (brcm,bus-gpio) for SoC GPIO chip · Rafał Miłecki <hidden>
On 09/27/2014 10:05 AM, Rafał Miłecki wrote:
On 27 September 2014 00:03, Arnd Bergmann [off-list ref] wrote:quoted
On Friday 26 September 2014 16:28:53 Rafał Miłecki wrote:quoted
+The top-level axi bus may contain following children: + +- gpio: GPIO chip on the SoC + + Required properties: + - compatible: "brcm,bus-gpio" + - gpio-controller : makes the node a GPIO controller + - #gpio-cells : size of the GPIO specifier, must be 2 +I wonder if it would be better to avoid the subnode here and just make the parent itself the gpio controller. Is the gpio controller part of the bus itself in reality, or is it a device that gets probed on the bus?I'm not sure how to treat this chip. We control GPIOs using ChipCommon regs (and ChipCommon is one of cores/devices on the bus), so you could also consider GPIO chip a sub-device of ChipCommon. I believe every Broadcom bus has a GPIO chip. In the ancient (MIPS) times, even if we didn't have ChipCommon, there was an EXTIF core that used to provide access to the GPIO chip. What do you think? Should I make it separated device, even it if depends on the SoC and its ChipCommon core (device)?
I would make GPIO a subdevive of chipcommon. The chipcommon core has an own IRQ which is also used for GPIO. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html