Thread (1 message) 1 message, 1 author, 2014-09-25

Re: [PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

From: Linus Walleij <hidden>
Date: 2014-09-25 08:45:35

On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik [off-list ref] wrote:
Add support for device-tree device discovery. If devicetree is not
provided, fallback to legacy platform data "discovery".

Signed-off-by: Robert Jarzmik <redacted>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
(...)
quoted hunk
@@ -2417,6 +2425,8 @@ static int pxa_udc_probe(struct platform_device *pdev)
        if (mach) {
                udc->gpiod = gpio_to_desc(mach->gpio_pullup);
                udc->udc_command = mach->udc_command;
+       } else {
+               udc->gpiod = devm_gpiod_get(&pdev->dev, NULL);
        }
Aha OK there it is.

devm_gpiod_get() actually uses three arguments now, you're using
a deprecated version of the interface:

struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                              const char *con_id,
                                              enum gpiod_flags flags);

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help