Re: [PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support

On 09/19/14 16:43, Sjoerd Simons wrote:

Hey Kukjin,

Hi,

Sorry for late response...

It's been almost a month since I posted the first iteration of this
patchset on the list, with only trivial cosmetic changes and an addition
of a similar fix for Arndale Octa boards. Do you feel it needs more
review from specific folks before pulling it in or ?

Seems a bit of a shame if this would fail to make it for 3.18 (one could
even argue the dt patches are 3.17 RC material!) as it fixes USB
functionality being broken depending on the kernel configuration used.


On Mon, 2014-09-15 at 12:52 +0200, Sjoerd Simons wrote:

quoted

When building a kernel with support for both USB host and USB Gadget support on
the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
otherwise specified in the dtb, which is unhelpful for boards hooked up to run
as USB host.

First patch in this set explicitely set the dual-role mode for the dwc3
controller on Peach pi and Peach pit boards to host mode. Second patch adds
similar updates for Arndale Octa as reported by Andreas Färber. Last patch
enables gadget mode in the default exynos config to more easily catch/trigger
issues like these.

I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
great if users of those board could verify this.

Changes in v2: alphabetically sort the dts entries
Changes in v3: Add DTS updates for arndale octa

Sjoerd Simons (3):
   ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
   ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
   ARM: exynos_defconfig: enable USB gadget support

  arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
  arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
  arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
  arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
  arch/arm/configs/exynos_defconfig             | 1 +
  5 files changed, 23 insertions(+), 2 deletions(-)

I have no objection on this series but needs to be rebased on my tree, 
can you please respin on top of my tree?

Thanks,
Kukjin
-- 
Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel