Re: [PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support

Hi David,

On Fri, 19 Sep 2014 15:10:02 +0200
David Herrmann [off-list ref] wrote:

Hi

On Mon, Sep 8, 2014 at 10:43 AM, Boris BREZILLON
[off-list ref] wrote:
[snip]

quoted

+static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
+{
+       int ret;
+
+       ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
+       if (ret)
+               return ret;
+
+       ret = drm_platform_init(&atmel_hlcdc_dc_driver, pdev);
+       if (ret)
+               return ret;

Please avoid any use of drm_platform_*(). Use drm_dev_alloc(),
drm_dev_register() directly. See my response on
  "[PATCH v3 1/5] drm/rockchip: Add basic drm driver":
for details. Also have a look at the tegra driver how to do it.

quoted

+
+       return 0;
+}
+
+static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev)
+{
+       drm_put_dev(platform_get_drvdata(pdev));

Same here: please use dev_dev_*() directly:

drm_dev_unregister(ddev);
drm_dev_unref(ddev);

Sure, I'll change that.

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com