Thread (3 messages) 3 messages, 2 authors, 2014-09-10

Re: [PATCH v3] ARM: l2c: parse cache properties from ePAPR definitions

flat view

From: Linus Walleij <hidden>
Date: 2014-09-10 10:44:16
Also in: linux-arm-kernel, linux-leds, linux-pm

On Wed, Sep 10, 2014 at 11:44 AM, Arnd Bergmann [off-list ref] wrote:
On Wednesday 10 September 2014 10:59:32 Linus Walleij wrote:
quoted
+     pr_info("L2C OF: override cache size: %d bytes (%dKB)\n",
+             cache_size, cache_size >> 10);
+     pr_info("L2C OF: override line size: %d bytes\n", line_size);
+     pr_info("L2C OF: override way size: %d bytes (%dKB)\n",
+             way_size, way_size >> 10);
+     pr_info("L2C OF: override associativity: %d\n", *associativity);
I think it would be really nice to print both the original setting
and the setting from DT here.
There is already some code printing the original setting, even
if it's cryptic, this is in __l2c_init():
L2C: DT/platform modifies aux control register: 0x02020fff -> 0x02030fff

boot value -> augmented value

If you mean that you want me to modify that debug code to provide
more verbose pretty-print I am happy to do so, but as a separate
patch.

The rest of the stuff I have fixed...

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help