Re: [PATCH v2] spi: orion: support armada extended baud rates

Hi Geert,

On 04/09/14 23:17, Geert Uytterhoeven wrote:

On Thu, Sep 4, 2014 at 2:54 PM,  [off-list ref] wrote:

quoted

The Armada SoC family implementation of this SPI hardware module has
extended the configuration register to allow for a wider range of SPI
clock rates. Specifically the Serial Baud Rate Pre-selection bits in the
SPI Interface Configuration Register now also use bits 6 and 7 as well.

Modify the baud rate calculation to handle these differences for the
Armada case. Potentially a baud rate can be setup using a number of
different pre-scalar and scalar combinations. This code tries all
possible pre-scalar divisors (8 in total) to try and find the most
accuate set.

Are the Orion rates and register bits a subset of the Armada ones?
I.e. does the Armada work with the Orion setup?

The bits used by the orion are a subset (bits 0-4 of the SPI
configuration register) of those used by the armada (bits 0-4 and
6-7).

In practice the defined prescalar values for the orion do give
the same divisor for the same bits set on armada. The extra bits
on the armada let you get to lower SPI baudrates (which is more of
a problem on the armada with its higher core clocks).

quoted

This change introduces a new device tree compatible device name
"armada-spi". This is used in place of "orion-spi" on the Armada SoC
parts.

quoted

-                               compatible = "marvell,orion-spi";
+                               compatible = "marvell,armada-spi";

If the answer to my above question is yes, you want to keep
"marvell,orion-spi" as a fallback.

Do you mean like this?

  compatible = "marvell,orion-spi", "marvell,armada-spi";

Regards
Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html