Thread (130 messages) 130 messages, 14 authors, 2014-10-07

Re: [RFC PATCH v2 07/16] gpio: Add support for unified device properties interface

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2014-09-24 09:38:43
Also in: linux-acpi, lkml

On Wed, Sep 24, 2014 at 11:12:36AM +0200, Arnd Bergmann wrote:
As a start, we could probably take the proposed device_for_each_child_node
and move that into the leds-core, changing the fw_dev_node argument
for an led_classdev with the addition of the of_node and acpi_object
members. It would still leave it up to the gpio-leds driver to do

	if (led_cdev->of_node)
		gpiod = devm_of_get_gpiod(led_cdev->of_node, ...);
	else
		gpiod = devm_acpi_get_gpiod(led_cdev->acpi_object, ...);

but there seems little benefit in abstracting this because there is
only one driver that needs it.
The same interface is used also in gpio_keys_polled.c driver so if we
want to avoid duplicating code this needs to be abstracted away from the
drivers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help