Re: [PATCH 2/3] cap1106: support for active-high interrupt option
From: Daniel Mack <daniel@zonque.org>
Date: 2014-09-21 10:06:34
Also in:
linux-input, lkml
On 09/21/2014 05:01 AM, Matt Ranostay wrote:
quoted hunk ↗ jump to hunk
Some applications need to use the active-high push-pull interrupt option. This allows it be enabled in the device tree child node. Signed-off-by: Matt Ranostay <redacted> --- drivers/input/keyboard/cap1106.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c index b9c43b5..33e2590 100644 --- a/drivers/input/keyboard/cap1106.c +++ b/drivers/input/keyboard/cap1106.c@@ -234,6 +234,12 @@ static int cap1106_i2c_probe(struct i2c_client *i2c_client, dev_err(dev, "Invalid sensor-gain value %d\n", gain32); } + if (of_property_read_bool(node, "microchip,active-high")) {
I think the name of that property should make clear it's only changing the interrupt output driver configuration. What about "microchip,irq-active-high"? Also, patch 3/3, which documents this new property, can be squashed into this one.
+ error = regmap_write(priv->regmap, CAP1106_REG_CONFIG2, 0);
This register controls a lot more details than that. Overriding it with 0 doesn't seem right. Please use regmap_update_bits() to just update ALT_POL, and also add a #define for it, so the next reader knows what the code is doing :) Thanks, Daniel