RE: [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
From: Chen, Alvin <hidden>
Date: 2014-09-17 07:10:05
Also in:
linux-gpio, lkml
From: Chen, Alvin <hidden>
Date: 2014-09-17 07:10:05
Also in:
linux-gpio, lkml
quoted
+ if (pp->idx == 0 && + of_property_read_bool(port_np, "interrupt-controller")) { + pp->irq = irq_of_parse_and_map(port_np, 0); + if (!pp->irq) { + dev_warn(dev, "no irq for bank %s\n", + port_np->full_name); + } + } else { + pp->irq = 0; + }The else clause is not needed since pp->irq == 0 already, right?
Yes, while call kcalloc, the memory is set to '0'. I will improve it.