quoted

quoted

quoted

Tested on the Marvell Berlin SoCs USB controllers.

Signed-off-by: Antoine Tenart <antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
 drivers/usb/chipidea/Makefile       |   1 +
 drivers/usb/chipidea/ci_hdrc_usb2.c | 137
++++++++++++++++++++++++++++++++++++
 2 files changed, 138 insertions(+)  create mode 100644
drivers/usb/chipidea/ci_hdrc_usb2.c

compile error:

/home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c: In

function 'ci_hdrc_usb2_dt_probe':

quoted

quoted

/home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30
:2: error: implicit declaration of function 'of_phy_get'
[-Werror=implicit-function-declaration]
/home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30
:16: warning: assignment makes pointer from integer without a cast
[enabled by default]

Did you apply the series introducing the support for the generic PHY
framework in the USB subsystem first? One of the patches includes
'linux/phy/phy.h' in 'linux/usb/otg.h'. That's why I did not encounter
this error.

Anyway, you're right and 'linux/phy/phy.h' should be explicitly
included here.

Let me know if you want me to quickly cook up a new version fixing this.

You can send this fix if you don't want to get comments for other parts in this
series.

I also see other dependencies like generic phy support for chipidea with this one.
I think the 7th and 8th in this series are ok after adding 'linux/phy/phy.h', but
you generic phy support series should be queued before this one.

Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html