Re: [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver

Hi, 

On Mon, 2014-09-15 at 11:30 -0400, Eduardo Valentin wrote:

Hey Ivan,

Please give us at least a two weeks time frame before resending your
patches.

Sure, I just wanted to add MSM mail list, sorry.

quoted

+
+Optional properties:
+- label:           A string used as a descriptive name for this thermal
+                   device. This name should be 19 characters or less.

This is a driver specific property and must be properly named as such.
Please read the the DT documentation.

I believe that it is standard property. Section 6.1.2.3 label. I could
drop this property. Node name should be enough descriptive, already.

More specifically, we already have standardized and discussed way of
describing thermal zones in DT, including their names. Please read
Documentation/devicetree/bindings/thermal/thermal.txt 

quoted

+- io-channels:     Should contain IIO channel specifier
+- io-channel-names: "thermal". The ADC channel for temperature reading.
+
+Example:
+
+	thermal-alarm@2400 {
+		compatible = "qcom,qpnp-temp-alarm";
+		reg = <0x2400>;
+		interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
+		label = "pm8941_tz";
+		io-channels = <&pm8941_vadc VADC_DIE_TEMP>;
+		io-channel-names = "thermal";
+	};

<snip>

quoted

+++ b/drivers/thermal/qpnp-temp-alarm.c

@@ -0,0 +1,519 @@
+/*
+ * Copyright (c) 2011-2014, The Linux Foundation. All rights reserved.
+ *

Is it really the Linux Foundation? Or would it be QC/Codeaurora copyrights here?

Yes, it is Linux Foundation. Downstream driver on this which driver is
based is also Linux Foundation copyrighted.

<snip>

quoted

+
+	rc = devm_request_irq(chip->dev, chip->irq, qpnp_tm_isr,
+			      IRQF_TRIGGER_RISING, chip->tm_name, chip);
+	if (rc < 0)
+		thermal_zone_device_unregister(chip->tz_dev);
+

This thermal driver does not bind to any cooling device?

This driver monitor temperature of the external PMIC chip, accessed over
SPMI bus. I am not aware of way how to cool this chip.

quoted

+	return rc;
+}
+

Regards,
Ivan