Re: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288
From: Heiko Stübner <heiko@sntech.de>
Date: 2014-09-09 11:35:25
Also in:
linux-arm-kernel, linux-pm, lkml
Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
quoted hunk ↗ jump to hunk
Signed-off-by: Caesar Wang <redacted> --- arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 36be7bb..3d672e3 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi@@ -224,6 +224,17 @@ status = "disabled"; }; + tsadc: tsadc@ff280000 {
please keep the list of nodes sorted by register address. So when looking at my v3.18-next/dts branch, it should be after uart4: serial@ff1c0000 and before usb_host0_ehci: usb@ff500000 .
quoted hunk ↗ jump to hunk
+ compatible = "rockchip,rk3288-tsadc"; + reg = <0xff280000 0x100>; + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>; + clock-names = "tsadc", "apb_pclk"; + pinctrl-names = "default"; + pinctrl-1 = <&tsadc_int>; + status = "disabled"; + }; + /* NOTE: ohci@ff520000 doesn't actually work on hardware */ usb_hsic: usb@ff5c0000 {@@ -611,5 +622,12 @@ rockchip,pins = <5 15 3 &pcfg_pull_none>; }; }; + + tsadc { + tsadc_int: tsadc-int { + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>; + }; + };
After looking this up in the schematics I see that this is the overtemperature-protection output pin ... labeled OTP_OUT. So I'd think the pinconfig should reflect this pin-name, especially as tsadc-int suggests, that this would be an interrupt leading into the tsadc, while in fact it is an output to a separate circuit. Heiko