On Fri, 2014-09-05 at 09:35 +0000, Chen, Alvin wrote:

quoted

Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote:

quoted

This patch enables 'debounce' for the designware GPIO, and it is based
on Josef Ahmad's previous work.

Can we split dwapb_read/write introducing and changing from this patch to a
separate one?

Since the 'debounce' feature also needs read/write, if we splite this patch, then for 'debounce',
One patch use readl/writel, and another patch change to dwapb_read/write. It seems duplicate since
the previous patch use readl/writel and the fllowing one change it immediately.
Since this patch is small, could we just make them together? How do you think?

Make the dwapb_writel/readl patch goes first in the series.

-- 
Andy Shevchenko [off-list ref]
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.