Re: [PATCH v9 1/3] RTC: RK808: add RTC driver for RK808

On Thu, Sep 04, 2014 at 12:04:11PM -0700, Doug Anderson wrote:

Dmitry,

On Thu, Sep 4, 2014 at 10:33 AM, Dmitry Torokhov
[off-list ref] wrote:

quoted

On Wed, Sep 03, 2014 at 09:18:42PM -0700, Doug Anderson wrote:

quoted

Chris,

On Wed, Sep 3, 2014 at 6:12 PM, Chris Zhong [off-list ref] wrote:

quoted

Adding RTC driver for supporting RTC device present inside RK808 PMIC.

Signed-off-by: Chris Zhong <redacted>
Signed-off-by: Zhang Qing <redacted>

Tested-by: Heiko Stuebner <redacted>

Reviewed-by: Doug Anderson <redacted>
Tested-by: Doug Anderson <redacted>

quoted

+       rk808_rtc->irq = platform_get_irq(pdev, 0);
+       if (rk808_rtc->irq < 0) {
+               dev_err(&pdev->dev, "Wake up is not possible as irq = %d\n",
+                       rk808_rtc->irq);

Technically you shouldn't print the error if it's -EPROBE_DEFER.
...but I think that's really unlikely here (I can't imagine any real
cases where the interrupt parent for RK808 would actually be deferred)
so I won't push it.

Doug, platform_get_irq() simply iterates through IRQ resources assigned to the
device, which are populated at platform device creation time. The only error it
returns ever is -ENXIO, so we are fine here.

I think maybe you're looking at older source code?  The source code I
have for mainline Linux specifically includes code handling
EPROBE_DEFER in platform_get_irq().

Ah, indeed. That -EPROBE_DEFER monstrosity keeps spreading :(

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html