On 31 July 2014 17:40, Doug Anderson [off-list ref] wrote:

Addy,

On Wed, Jul 30, 2014 at 11:01 PM, Addy Ke [off-list ref] wrote:

quoted

This patch focuses on clock setting for RK3288 mmc controller.

In RK3288 mmc controller, CLKDIV register can only be set 0 or 1,
and if DDR 8bit mode, CLKDIV register must be set 1.

Reported-by Doug Anderson [off-list ref]
Suggested-by: Jaehoon Chung <jh80.chung@samsung.com>
Suggested-by: Doug Anderson <dianders@chromium.org>

You don't need "Suggested-by" and "Reported-by" for people who
reviewed your patch.  Suggested-by is usually when someone suggested
an overall feature and Reported-by is usually when someone reported a
bug in code that already landed.

You could add me as a Signed-off-by, though, since you folded in some
code that I wrote.

I think whoever applies this could fixup the tags, so:

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>

Thanks! Queued for 3.18, with corrected tags.

Kind regards
Uffe

It would be great to see this applied unless there are other objections.  :)

-Doug