On Aug 21, 2014 3:42 AM, "Michal Simek" [off-list ref] wrote:

On 08/20/2014 05:56 PM, Soren Brinkmann wrote:

quoted

Add missing Ethernet phys to Zynq DTs.

Signed-off-by: Soren Brinkmann <redacted>
---
 arch/arm/boot/dts/zynq-zc702.dts | 6 ++++++
 arch/arm/boot/dts/zynq-zc706.dts | 6 ++++++
 arch/arm/boot/dts/zynq-zed.dts   | 6 ++++++
 3 files changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/zynq-zc702.dts

b/arch/arm/boot/dts/zynq-zc702.dts

quoted

index 30bcfe20f0bc..fa810505ab8f 100644

--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts

@@ -36,6 +36,12 @@
 &gem0 {
      status = "okay";
      phy-mode = "rgmii-id";
+     phy-handle = <&ethernet_phy>;
+
+     ethernet_phy: ethernet-phy@7 {
+             compatible = "marvell,88e1116r",

"ethernet-phy-ieee802.3-c22";

c22 is completely unused by the kernel and also c22 is default option

anyway.

Which does not preclude you from following the binding defined in phy.txt,
and that binding mandates a valid compatible property.

Any advantage to have c22 specified here?

We need to differentiate a clause 22 only PHY from a clause 45 compatible
PHY.

Soren's changes are good and are the recommended way to do it.

Thanks,
Michal


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel