Thread (1 message) 1 message, 1 author, 2014-08-28

Fwd: [PATCH] x86/devicetree: Fix compile warnings on AMD64

From: Ricardo Ribalda Delgado <hidden>
Date: 2014-08-28 13:04:04
Subsystem: the rest, x86 architecture (32-bit and 64-bit) · Maintainers: Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen

Possibly related (same subject, not in this thread)

---------- Forwarded message ----------
From: Ricardo Ribalda Delgado <redacted>
Date: Tue, Aug 5, 2014 at 11:19 AM
Subject: [PATCH] x86/devicetree: Fix compile warnings on AMD64
To: Thomas Gleixner <redacted>, Ingo Molnar
[off-list ref], "H. Peter Anvin" [off-list ref], x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Grant Likely [off-list ref], Rob Herring [off-list ref],
Michal Simek [off-list ref], Tony Lindgren [off-list ref],
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Ricardo Ribalda Delgado <redacted>


arch/x86/kernel/devicetree.c: In function ‘ioapic_xlate’:
arch/x86/kernel/devicetree.c:294:8: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  idx = (__force u32) domain->host_data;
        ^
arch/x86/kernel/devicetree.c: In function ‘dt_add_ioapic_domain’:
arch/x86/kernel/devicetree.c:323:4: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
    (void *)ioapic_num);

Signed-off-by: Ricardo Ribalda Delgado <redacted>
---
 arch/x86/kernel/devicetree.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
index 7db54b5..a481d1b 100644
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -278,7 +278,8 @@ static int ioapic_xlate(struct irq_domain *domain,
 {
        struct io_apic_irq_attr attr;
        struct of_ioapic_type *it;
-       u32 line, idx;
+       u32 line;
+       unsigned long idx;
        int rc;

        if (WARN_ON(intsize < 2))
@@ -291,7 +292,7 @@ static int ioapic_xlate(struct irq_domain *domain,

        it = &of_ioapic_type[intspec[1]];

-       idx = (u32) domain->host_data;
+       idx = (unsigned long) domain->host_data;
        set_io_apic_irq_attr(&attr, idx, line, it->trigger, it->polarity);

        rc = io_apic_setup_irq_pin_once(irq_find_mapping(domain, line),
@@ -320,7 +321,7 @@ static void dt_add_ioapic_domain(unsigned int ioapic_num,
        num = gsi_cfg->gsi_end - gsi_cfg->gsi_base + 1;

        id = irq_domain_add_linear(np, num, &ioapic_irq_domain_ops,
-                       (void *)ioapic_num);
+                       (void *)((unsigned long)ioapic_num));
        BUG_ON(!id);
        if (gsi_cfg->gsi_base == 0) {
                /*
--
2.0.1



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help