Re: [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string
From: Olof Johansson <hidden>
Date: 2014-08-27 22:01:11
Also in:
linux-arm-kernel
On Thu, Aug 14, 2014 at 2:46 AM, Daniel Mack [off-list ref] wrote:
quoted hunk
The vendor prefix was renamed from "mrvl" to "marvell". Follow this change in the dts file. Signed-off-by: Daniel Mack <redacted> --- arch/arm/boot/dts/pxa2xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index febd391..f188f8c 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi +++ b/arch/arm/boot/dts/pxa2xx.dtsi@@ -128,7 +128,7 @@ }; mmc0: mmc@41100000 { - compatible = "mrvl,pxa-mmc"; + compatible = "marvell,pxa-mmc";
It seems that the driver was changed without consideration to backwards compatibility. The driver should still handle both the old and the new prefix (since we keep this a stable ABI). The old one should be deprecated but still accepted. I.e. this is an OK change, but it's fine to hold off as a cleanup until 3.18. The driver has a regression though, that needs to be fixed for 3.17. -Olof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html