Thread (1 message) 1 message, 1 author, 2014-08-24

Re: [RFC 2/7] bcm47xx-nvram: add new broadcom nvram driver with dt support

From: Rafał Miłecki <hidden>
Date: 2014-08-24 21:45:38
Also in: linux-arm-kernel, linux-mips, linux-wireless

Possibly related (same subject, not in this thread)

On 24 August 2014 21:24, Hauke Mehrtens [off-list ref] wrote:
This was copied from arch/mips/bcm47xx/nvram.c and modified to interact
with device tree. My plan is to make the MIPS bcm47xx also use this new
driver some time later.
I don't like this.

First, you change API (_getenv call), without explanation why/if we
really need this. We decided we're very unlikely to ever find devices
with multiple (separated) NVRAMs. So what's the point of having nvram
per device?

Secondly, don't duplicate the code. If you're going to switch bcm47xx
to this new code, handle it smarter. Modify bcm47xx mode, move it to
the "misc" and re-use in bcm53xx.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help