Re: [PATCH v2 3/3] [media] rc: remove change_protocol in rc-ir-raw.c
From: Mauro Carvalho Chehab <hidden>
Date: 2014-08-21 11:50:06
Also in:
linux-arm-kernel, linux-media
Em Thu, 21 Aug 2014 17:24:45 +0800 Zhangfei Gao [off-list ref] escreveu:
With commit 4924a311a62f ("[media] rc-core: rename ir-raw.c"),
empty change_protocol was introduced.
No. This was introduced on this changeset:
commit da6e162d6a4607362f8478c715c797d84d449f8b
Author: David Härdeman [off-list ref]
Date: Thu Apr 3 20:32:16 2014 -0300
[media] rc-core: simplify sysfs code
As a result, rc_register_device will set dev->enabled_protocols addording to rc_map->rc_type, which prevent using all protocols.
I strongly suspect that this patch will break some things, as the new code seems to expect that this is always be set. See the code at store_protocols(): if this callback is not set, then it won't allow to disable a protocol. Also, this doesn't prevent using all protocols. You can still use "ir-keytable -p all" to enable all protocols (the "all" protocol type were introduced recently at the userspace tool).
From the way I see, setting the protocol when a table is loaded
is not a bad thing, as: - if RC tables are loaded, the needed protocol to decode it is already known; - by running just one IR decoder, the IR handling routine will be faster and will consume less power; - on a real case scenario, it is a way more likely that just one decoder will ever be needed by the end user. So, I think that this is just annoying for developers when are checking if all decoders are working, by sending keycodes from different IR types at the same time.
quoted hunk ↗ jump to hunk
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- drivers/media/rc/rc-ir-raw.c | 7 ------- 1 file changed, 7 deletions(-)diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index e8fff2a..a118539 100644 --- a/drivers/media/rc/rc-ir-raw.c +++ b/drivers/media/rc/rc-ir-raw.c@@ -240,12 +240,6 @@ ir_raw_get_allowed_protocols(void) return protocols; } -static int change_protocol(struct rc_dev *dev, u64 *rc_type) -{ - /* the caller will update dev->enabled_protocols */ - return 0; -} - /* * Used to (un)register raw event clients */@@ -263,7 +257,6 @@ int ir_raw_event_register(struct rc_dev *dev) dev->raw->dev = dev; dev->enabled_protocols = ~0; - dev->change_protocol = change_protocol; rc = kfifo_alloc(&dev->raw->kfifo, sizeof(struct ir_raw_event) * MAX_IR_EVENT_SIZE, GFP_KERNEL);
-- Cheers, Mauro