Thread (29 messages) 29 messages, 7 authors, 2014-09-06

Re: [PATCH 5/7] ARM: meson: dts: add basic Meson/Meson6/Meson6-atv1200 DTSI/DTS

From: Carlo Caione <hidden>
Date: 2014-08-17 15:21:23
Also in: linux-arm-kernel, linux-serial

On Sun, Aug 17, 2014 at 4:42 PM, Beniamino Galvani [off-list ref] wrote:
Hi,
quoted
+/include/ "meson.dtsi"
+
+/ {
+     model = "Amlogic Meson6 SoC";
+     compatible = "amlogic,meson6", "amlogic,8726_mx";
+
+     interrupt-parent = <&gic>;
+
+     cpus {
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             cpu@0 {
The address after the @ should match the value of the 'reg' property.
Agree
quoted
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     reg = <0x200>;
+             };
+
+             cpu@1 {
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     reg = <0x1>;
According to Documentation/devicetree/bindings/arm/cpus.txt, this
should be set to bits [23:0] of the CPU MPIDR register, in this case
0x201.
Right. Thanks for noticing.
I will fix it in v2.

Thank you,

-- 
Carlo Caione
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help