Thread (6 messages) 6 messages, 4 authors, 2014-08-30

Re: [PATCH 0/2] rockchip-i2s: add power setting for I2S controller and fix some critical bugs

From: Heiko Stübner <hidden>
Date: 2014-08-30 18:53:25
Also in: alsa-devel, lkml

Am Freitag, 29. August 2014, 21:30:43 schrieb Doug Anderson:
Jianqun,

On Fri, Aug 29, 2014 at 3:07 PM, Jianqun [off-list ref] wrote:
quoted
Add optional power setting for i2s controller found on rk3066, rk3168 and
rk3288 processors from rockchip, should according to hardware design.

Default setting for I2S controller is powered by 3.3V, there needs this
patch if it's powered by 1.8V by hardware design.

Jianqun (2):
  rockchip-i2s: dt: add grf requested properties to set power of I2S
  controller rockchip-i2s: add power setting for I2S controller, also fix
  some bugs>  
 .../devicetree/bindings/sound/rockchip-i2s.txt     |  6 +-
 sound/soc/rockchip/rockchip_i2s.c                  | 93
 +++++++++++++--------- sound/soc/rockchip/rockchip_i2s.h                
  | 13 +--
 3 files changed, 68 insertions(+), 44 deletions(-)
Did the general solution I posted at
<https://patchwork.kernel.org/patch/4807821/> not work for you?  ...or
did you not see that?
Also, I don't think it's a good idea to set the io voltage bit simply from a 
dt setting without looking at the actual regulator voltage ... as a 1.8V 
setting when the regulator supplies 3.3V supposedly is able to damage the 
chip.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help