Re: [PATCH v9 02/12] PCI: OF: Parse and map the IRQ when adding the PCI device.
From: Wei Yang <hidden>
Date: 2014-08-14 14:58:19
Also in:
linux-arch, linux-arm-kernel, linux-pci, lkml
On Tue, Aug 12, 2014 at 05:25:15PM +0100, Liviu Dudau wrote:
quoted hunk ↗ jump to hunk
Enhance the default implementation of pcibios_add_device() to parse and map the IRQ of the device if a DT binding is available. Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Grant Likely <redacted> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> --- drivers/pci/pci.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 1c8592b..29d1775 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c@@ -17,6 +17,7 @@#include <linux/spinlock.h> #include <linux/string.h> #include <linux/log2.h> +#include <linux/of_pci.h> #include <linux/pci-aspm.h> #include <linux/pm_wakeup.h> #include <linux/interrupt.h>@@ -1453,6 +1454,8 @@ EXPORT_SYMBOL(pcim_pin_device); */int __weak pcibios_add_device(struct pci_dev *dev) { + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); + return 0; }
Liviu, For this, my suggestion is to add arch dependent function to setup the irq line for pci devices. I can't find an obvious reason this won't work on other archs, but maybe this will hurt some of them?
-- 2.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Richard Yang Help you, Help me