Re: [PATCH] of: Deep-copy names of platform devices
From: Stephen Boyd <hidden>
Date: 2014-08-13 01:46:40
Also in:
linux-arm-msm, lkml
On 08/12/14 17:57, Stepan Moskovchenko wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/of/device.c b/drivers/of/device.c index f685e55..3e116f6 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c@@ -54,7 +54,7 @@ int of_device_add(struct platform_device *ofdev) /* name and id have to be set so that the platform bus doesn't get * confused on matching */ - ofdev->name = dev_name(&ofdev->dev); + ofdev->name = kstrdup(dev_name(&ofdev->dev), GFP_KERNEL); ofdev->id = -1; /* device_add will assume that this device is on the same node as@@ -76,6 +76,7 @@ EXPORT_SYMBOL(of_device_register); void of_device_unregister(struct platform_device *ofdev) { device_unregister(&ofdev->dev); + kfree(ofdev->name);
This probably ought to be swapped because we don't know if ofdev isn't pointing to freed memory after device_unregister(). -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation