Hi Sebastian,

can you please take this series (I'll post update version with
removing debug code). Thanks.

On Thu, Mar 6, 2014 at 10:10 PM, Belisko Marek [off-list ref] wrote:

Hi Sebastian,

On Thu, Mar 6, 2014 at 12:25 AM, Sebastian Reichel [off-list ref] wrote:

quoted

Hi Marek,

I just have one comment:

On Wed, Mar 05, 2014 at 09:52:17PM +0100, Marek Belisko wrote:

quoted

[...]
-static int madc_read(int index)
+static int madc_read(struct iio_channel *channel)
 {
-     struct twl4030_madc_request req;
-     int val;
-
-     req.channels = index;
-     req.method = TWL4030_MADC_SW2;
-     req.type = TWL4030_MADC_WAIT;
-     req.do_avg = 0;
-     req.raw = false;
-     req.func_cb = NULL;
-
-     val = twl4030_madc_conversion(&req);
-     if (val < 0)
-             return val;
-
-     return req.rbuf[ffs(index) - 1];
+     int val, err;
+     err = iio_read_channel_processed(channel, &val);
+     if (err < 0) {
+             pr_info("Error:%d\n", err);

This should be "Error: %d\n" (with a space).

Ups this is remain from debugging messages. I'll remove it and re-post patches.
Thanks.

quoted

Apart from that you should use dev_info() or dev_err(), so that the
message is properly prefixed by the device. Currently there is no
hint where this error message is generated.

quoted

+             return err;
+     }
+     return val;
 }
[...]

After fixing this you can add

Reviewed-By: Sebastian Reichel <redacted>

-- Sebastian

BR,

marek

--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com