Re: [PATCH] mtd: add driver for the flash in Lattice machxo2 FPGAs

On 07/25/2014 01:33 PM, Martin Fuzzey wrote:

(...)

+

quoted

quoted

+static void machxo2_lock(struct machxo2 *machxo2)
+{
+    if (!mutex_trylock(&machxo2->lock)) {
+        dev_dbg(machxo2->dev, "wait for %s from %pf\n",
+                __func__, __builtin_return_address(0));
+

dev_dbg(machxo2->dev, "wait for %s from %pf\n",
    __func__, __builtin_return_address(0));

Sorry, not understanding here.
You want the second line to be LESS intented??

Coding style (chapter 2) says:
    Descendants are always substantially shorter than the parent and
    are placed substantially to the right

Idem for the others

this is the problem with my email client sorry.. 2nd line should start exactly
below 'm' in machxo2->dev...
  
dev_dbg(machxo2->dev, "wait for %s from %pf\n",
	__func__, __builtin_return_address(0));

quoted

+static int machxo2_transceive(

quoted

+            struct machxo2 *machxo2,
+            const void *send_buf, unsigned send_len,
+            void *recv_buf, unsigned recv_len)

(...)

quoted

quoted

+struct machxo2 *machxo2_create(struct device *dev,
+            struct machxo2_busops *busops);
+

struct machxo2 *machxo2_create(struct device *dev,
                   struct machxo2_busops *busops);

Same again - is it just too much indenting?
I don't see anything wrong here

same...


-- 
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html