Re: [PATCH RFC 2/2] regulator: twl: Re-add clk32kg to get wifi working

On 16.07.2014 23:23, Mark Brown wrote:

On Tue, Jul 15, 2014 at 02:59:14PM +0200, Stefan Assmann wrote:

quoted

Looking at this more closely it seems to me that it's a regulator thing
after all. In the end it all boils down to a single register write.
twl_i2c_write_u8(TWL_MODULE_PM_RECEIVER, 0x41, 0x8e);
This is a write to the CLK32KG_CFG_STATE [1] register to power on the
device.

The register description happening to mention power doesn't mean it's
not functionally an enable for a clock.

quoted

I tried moving that to omap4xxx_dt_clk_init() but that won't work
because the twl core structures aren't initialized yet.

quoted

Any suggestions?

Why not just add this to (or create a new) clock driver for the chip?

Problem is that twl_i2c_write_u8() calls twl_get_regmap() to get the
regmap. This requires struct twl_priv to be populated which does not
happen until twl_probe has run. That hasn't happened at the point when
omap4xxx_dt_clk_init() gets called.
Is there a way to defer a clock driver until twl_probe() has run?

   Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html