Re: [PATCH 4/8] clk: Add clock driver for mb86s7x
From: Arnd Bergmann <hidden>
Date: 2014-07-14 14:08:57
Also in:
linux-arm-kernel
On Sunday 13 July 2014 14:30:52 Mollie Wu wrote:
quoted hunk
--- .../bindings/clock/fujitsu,mb86s7x_clk.txt | 32 ++ drivers/clk/Makefile | 1 + drivers/clk/clk-mb86s7x.c | 352 +++++++++++++++++++++ 3 files changed, 385 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/fujitsu,mb86s7x_clk.txt create mode 100644 drivers/clk/clk-mb86s7x.cdiff --git a/Documentation/devicetree/bindings/clock/fujitsu,mb86s7x_clk.txt b/Documentation/devicetree/bindings/clock/fujitsu,mb86s7x_clk.txt new file mode 100644 index 0000000..4a17d79 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/fujitsu,mb86s7x_clk.txt@@ -0,0 +1,32 @@ +Fujitsu CRG11 clock driver bindings +----------------------------------- + +Required properties : +- compatible : Shall contain "fujitsu,mb86s7x_clk"
No wildcards in compatible strings please.
+- #clock-cells : Shall be 0 +- cntrlr : 0->ALW, 1->DDR3, 2->MAIN, 3->CA15, 4->HDMI, 5->DPHY +- domain : [0, 15] +- port : [0,7] -> Gateable Clock Ports. [8]->UngatedCLK
It would be good to be a bit more verbose here.
+
+struct clk *mb86s7x_clclk_register(struct device *cpu_dev)
+{
+ struct clk_init_data init;
+ struct cl_clk *clc;
+
+ clc = kzalloc(sizeof(*clc), GFP_KERNEL);
+ if (!clc) {
+ pr_err("could not allocate cl_clk\n");
+ return ERR_PTR(-ENOMEM);
+ }
+
+ clc->hw.init = &init;
+ clc->cluster = topology_physical_package_id(cpu_dev->id);
+
+ init.name = dev_name(cpu_dev);
+ init.ops = &clk_clc_ops;
+ init.flags = CLK_IS_ROOT | CLK_GET_RATE_NOCACHE;
+ init.num_parents = 0;
+
+ return devm_clk_register(cpu_dev, &clc->hw);
+}
+
+static int mb86s7x_clclk_of_init(void)
+{
+ int cpu;
+ struct clk *clk;
+
+ for_each_possible_cpu(cpu) {
+ struct device *cpu_dev = get_cpu_device(cpu);
+
+ if (!cpu_dev) {
+ pr_err("failed to get cpu%d device\n", cpu);
+ continue;
+ }
+
+ clk = mb86s7x_clclk_register(cpu_dev);
+ if (IS_ERR(clk)) {
+ pr_err("failed to register cpu%d clock\n", cpu);
+ continue;
+ }
+ if (clk_register_clkdev(clk, NULL, dev_name(cpu_dev))) {
+ pr_err("failed to register cpu%d clock lookup\n", cpu);
+ continue;
+ }
+ pr_debug("registered clk for %s\n", dev_name(cpu_dev));
+ }
+
+ platform_device_register_simple("arm-bL-cpufreq-dt", -1, NULL, 0);
+
+ return 0;
+}
+module_init(mb86s7x_clclk_of_init);This looks weird: why don't you probe the clocks from DT like normal? Why do you register a platform device here? Are you trying to hide the fact that the cpufreq stuff still doesn't use proper DT probing? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html