Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

On Mon, 2014-07-07 at 22:56 -0500, Jain Priyanka-B32167 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, July 08, 2014 3:00 AM
To: Jain Priyanka-B32167
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for
board

On Mon, 2014-07-07 at 14:06 +0530, Priyanka Jain wrote:

quoted

Signed-off-by: Priyanka Jain <redacted>
---
 .../devicetree/bindings/powerpc/fsl/board.txt      |   17

++++++++++++++++-

quoted

 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt

b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
index f35f295..7800729 100644

--- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt

@@ -1,8 +1,23 @@
 Freescale Reference Board Bindings

-This document describes device tree bindings for various devices that
+This document describes device tree bindings for board and  various
+devices that
 exist on some Freescale reference boards.

+* Board node
+Required properties:
+
+ - model : Should be "fsl,<board>"
+ - compatible : Should be "fsl,<board>"
+	example: "fsl,T1040RDB", "fsl,T1042RDB", "fsl,T1042RDB_PI"
+		 "fsl,T1040QDS", "fsl,T1042QDS"
+
+Example:
+
+/ {
+	model = "fsl,T1040RDB";
+	compatible = "fsl,T1040RDB";
+};

We really don't need to do this for every board just to satisfy
checkpatch.

-Scott

[Jain Priyanka-B32167] Is it OK to submit a patch with board checkpatch warning for this case ?

If you mean "is it OK to submit a board patch that has checkpatch
warnings of this sort, where the compatible follows a well established
pattern", then yes.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html